Revert "Revert "Update media3 to 1.9.2""#2510
Open
Luna712 wants to merge 2 commits intorecloudstream:masterfrom
Open
Revert "Revert "Update media3 to 1.9.2""#2510Luna712 wants to merge 2 commits intorecloudstream:masterfrom
Luna712 wants to merge 2 commits intorecloudstream:masterfrom
Conversation
Contributor
Author
|
@fire-light42 I've tested that this does fix the crashes I'm aware of. Unless there was something else also? |
Collaborator
|
It is not necessary to downgrade the NextLib, we only need to override the NextRenderersFactory buildTextRenderers. |
Contributor
Author
I guess thats true. Can that be a separate patch, or someone else can commit to this one? I apologize I'm unable to do much more work here right now due to being much more busy IRL now so it will be awhile before I could get to that if so, and I would like media3 updated anyway to fix some safe mode crashes that happens sometimes in particular. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2509
#2342 (comment)